rpc: skip bootstrap nodes that are lower than last checkpoint #8519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selsta
force-pushed
the
bootstrap-checkpoint
branch
from
928bb44
to
8f944ab
Compare
serhack
reviewed
Aug 20, 2022
Hmm, I don't see "50" anywhere in this code. |
|
hmm, messed something up in git, will update |
selsta
force-pushed
the
bootstrap-checkpoint
branch
from
8f944ab
to
07fcb59
Compare
selsta
force-pushed
the
bootstrap-checkpoint
branch
from
07fcb59
to
8702dca
Compare
|
Verified that it initializes correctly, and tested on mainnet, testnet and stagenet. |
jeffro256
suggested changes
Aug 23, 2022
selsta
force-pushed
the
bootstrap-checkpoint
branch
from
8702dca
to
7dcc89a
Compare
|
@jeffro256 thanks, totally forgot to make it const |
selsta
force-pushed
the
bootstrap-checkpoint
branch
from
7dcc89a
to
2639c4f
Compare
|
Updated, with #8544 it isn't necessary anymore to set a custom fail points. This also makes the diff smaller. |
j-berman
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also outdated nodes now get 50 fail points instead of 2.Not necessary anymore with #8544.